BatchNode: Fix IndexOutOfBoundsException #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There are temporary arrays that are reused to work with vertex buffers. - Some conditions cause the index to be used for storing more vertices that they can hold. - This throws the exception. - This fix validates the arrays size before accessing them, recreating the arrays if they are too small.
jcfandino
changed the title
stephengold
reviewed
Jul 30, 2024
|
@jcfandino thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are temporary arrays that are reused to work with vertex buffers.
Some conditions cause the arrays to be used for storing more vertices that they can hold.
This throws the exception.
This fix validates the arrays size before accessing them, recreating the arrays if they are too small.
Fixes #2296