Add support for Smart Lithium #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you get verification from others? |
|
did it finally get tested? |
|
It looks sensible enough. I noticed one N/A value from the docs isn't handled here. I don't own these devices so I can't test them myself. I'll merge the change and make a couple of tweaks and hope for the best. |
|
excellent.. i can test after the updates are merged into signalk-victron-ble plugin, thanks for all your efforts.. looking forward to signalk having access to “all” my battery details.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to port keshavdv#47 to this fork. Please doublecheck if everything is correct, because I have no Python experience and did not test it.
Summary 📝
Add initial support for smart lithium batteries
Details
I've implemented the parsing based on the pdf and tested on a bunch of 160Ah batteries. @stefanor worked together with Victron to fix the byte order, and the data gathered with this code seems to match what the VictronConnect app says.