Add support for Smart Battery Protect #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is missing checks for N/A values described in the Victron documentation. I will merge it then add those checks. Unfortunately I don't own one of these devices to test it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to port keshavdv#48 to this fork. Please doublecheck if everything is correct, because I have no Python experience and did not test it.
Summary 📝
This adds support for the Smart Battery Protect; implemented using the Victron extra manufacturer data PDF and tested locally. Added tests and confirmed the linters passed.
Details - I had originally implemented Smart Lithium as part of this branch, but I see there is already a pull request for that, so I limited this just to Smart Battery Protect.