change hook triggering iosAddTarget.js. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded to xcode project.
NiklasMerz
approved these changes
Sep 24, 2019
JaimeFerBec
pushed a commit
to JaimeFerBec/cordova-plugin-openwith
that referenced
this pull request
Oct 10, 2019
rdcdev
approved these changes
Nov 12, 2019
BenjaminPoncet
pushed a commit
to BenjaminPoncet/cordova-plugin-openwith
that referenced
this pull request
Mar 4, 2020
…ded to xcode project. (j3k0#72)
BenjaminPoncet
added a commit
to BenjaminPoncet/cordova-plugin-openwith
that referenced
this pull request
Mar 4, 2020
dnlek
added a commit
to dnlek/cordova-plugin-openwith
that referenced
this pull request
Jul 22, 2021
into j3k0-master * 'master' of https://github.com/j3k0/cordova-plugin-openwith: Fix missing quotes Change code sign indentity and style Fix async call Added a copy files to after install hook IOS : Fix __BUNDLE_IDENTIFIER__ to prevent double suffix IOS : Add ShareExtension-Entitlements.plist to package.json IOS : Remove "iOS Setup" section IOS : Fix App Group creation and fix Share Extension Bundle Identifier IOS : Fix getCordovaParameter() to use package.json Because after_prepare hook does not pass installation variables in process.argv IOS : Move hooks on before and after prepare This allows ShareExtension to be created and updated in any case 2.0.0 Bump version 2.0.0 change hook triggering iosAddTarget.js. Fixes the target not being added to xcode project. (j3k0#72) Fix iOS build flags (j3k0#84) Fix extension crash on iOS 13 (j3k0#69) 1.3.0 Set version in plugin.xml
dnlek
added a commit
to dnlek/cordova-plugin-openwith
that referenced
this pull request
Jul 22, 2021
* j3k0-master: Fix missing quotes Change code sign indentity and style Fix async call Added a copy files to after install hook IOS : Fix __BUNDLE_IDENTIFIER__ to prevent double suffix IOS : Add ShareExtension-Entitlements.plist to package.json IOS : Remove "iOS Setup" section IOS : Fix App Group creation and fix Share Extension Bundle Identifier IOS : Fix getCordovaParameter() to use package.json Because after_prepare hook does not pass installation variables in process.argv IOS : Move hooks on before and after prepare This allows ShareExtension to be created and updated in any case 2.0.0 Bump version 2.0.0 change hook triggering iosAddTarget.js. Fixes the target not being added to xcode project. (j3k0#72) Fix iOS build flags (j3k0#84) Fix extension crash on iOS 13 (j3k0#69) 1.3.0 Set version in plugin.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If the plugin is already installed, iosAddTarget.js will not be triggered. You have to remove and re add the plugin each times.
These issues are related:
#60
EternallLight/cordova-plugin-openwith-ios#19
Solution, change hook from after_plugin_install to after_plugin_add which is triggered even if the plugin is already installed