Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Upgrade (X4291) #45

Merged
merged 17 commits into from
Jan 14, 2025
Merged

PHP Upgrade (X4291) #45

merged 17 commits into from
Jan 14, 2025

Conversation

rtucek
Copy link
Member

@rtucek rtucek commented Dec 29, 2024 •
edited
Loading

Changes:

  • Minor adjustments to LICENSE.md & README.md (b054953, 418c20d)
  • Drop CHANGELOG.md as it's not maintained whatsoever. Instead, people should rely on Github's release page.
  • Dropping support for outdated PHP versions and only focusing on hardening for all relevant and non-EOL PHP versions at the time of this writing in December 2024 (0fb5309, e75f2e2)
  • Adding PHPStan checks and fixes for Level 3 (d6e435e, 7158bff, 2489e1a, 93044dd, 25595a2)
  • Have PHPStan being executed in Github Workflow CI pipeline (927773e, 9c56626)
  • Add parallel-lint check to the Github CI workflow pipeline (3ca3da0)
Supported PHP versions as of 2024-12

From https://www.php.net/supported-versions.php

image

rtucek added 16 commits December 25, 2024 03:29
@rtucek
Require PHP v8.1 or above
0fb5309 
Any older version is already EOL and as such, we're not willing to necroboost
outdated PHP versions.
@rtucek
Add PHPStan checks and fix Level 0 findings
d6e435e
@rtucek
Add PHPStan checks and fix Level 1 findings
7158bff
@rtucek
Add PHPStan checks and fix Level 2 findings
2489e1a
@rtucek
Add required extensions
afac77d
@rtucek
Fix return type's DocBlock
74825bf
@rtucek
Explicitly allow only officially supported psr/log versions
bffe065
@rtucek
Add exmples to PHPStan check + fixes
a42a0ff
@rtucek
Update LICENSE.md
b054953
@rtucek
Update PHP requirement
e75f2e2 
In alignment with 0fb5309
@rtucek
Update examples in README.md
418c20d
@rtucek
Add Github workflow for running PHPStan checks
927773e
@rtucek
Drop CHANGELOG.md as it's not maintained whatsoever
1b18fa6 
Instead, people should rely on [Github's release page](https://github.com/ixopay/php-ixopay/releases).
@rtucek
Bump PHPStan to Level 3
93044dd
@rtucek
Don't use fast-fail=true
9c56626
@rtucek
Provide fixes for PHPStan Level 3 findings
25595a2
@rtucek rtucek mentioned this pull request Dec 29, 2024
Closed
@rtucek rtucek self-assigned this Dec 29, 2024
@rtucek rtucek requested a review from SPie December 29, 2024 01:04
@rtucek rtucek changed the title Prepare for PHP Upgrade (X4291) PHP Upgrade (X4291) Dec 29, 2024
@rtucek rtucek requested a review from SPie January 8, 2025 13:38
@rtucek rtucek merged commit 1cd5b8a into main Jan 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPie SPie SPie approved these changes

Assignees

@rtucek rtucek

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtucek @SPie