Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: jax, numpy, torch - math.tensorflow.math.reduce_prod #28542

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 11, 2024

PR Description

Test was failing because of small floating point rounding difference and too small/large values causing the results to be inf in some frameworks.
Fixed by adding tolerance and min max x values.

Related Issue

Close #28541
Close #28540
Close #28539

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Mar 11, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZJay07
Thank you very much for the PR.
Maybe we should use safety factors instead of specifying min max values

@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 16, 2024

Oh, what do you mean by a safety factor, do you mind giving me an example?

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safety factor ensures values are bounded based on dtype instead of just hardcoded min or max. You can see it used with test_tensorflow_reduce_std in the same file.

@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 31, 2024

Updated with safety factors similar to reduce_std. Let me know if this is correct.

@ZJay07 ZJay07 requested a review from Ishticode March 31, 2024 12:51
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZJay07 for the fix :)

@Ishticode Ishticode merged commit 7e63253 into ivy-llc:main Apr 2, 2024
231 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
3 participants