Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stat.py #21764

Closed
wants to merge 1 commit into from
Closed

Update stat.py #21764

wants to merge 1 commit into from

Conversation

praveen8ae
Copy link

@praveen8ae praveen8ae commented Aug 12, 2023

Added var function
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 12, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@praveen8ae praveen8ae mentioned this pull request Aug 12, 2023
Copy link
Contributor

@AryanSharma21 AryanSharma21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hry @praveen8ae , you should edit the Description and write the closing tag as
close #issue_number to properly link the issue with the pull request.

The - [ ] #issue_number tag should go under the to do list comments from where you have selected this issue to work.

Also, while implementing an API function you should also be writing test function to make sure the function behaves properly.
Thanks 😊

@AryanSharma21
Copy link
Contributor

You can read about contribution basics in the ivy docs as well

@praveen8ae
Copy link
Author

Hry @praveen8ae , you should edit the Description and write the closing tag as close #issue_number to properly link the issue with the pull request.

The - [ ] #issue_number tag should go under the to do list comments from where you have selected this issue to work.

Also, while implementing an API function you should also be writing test function to make sure the function behaves properly. Thanks 😊

can you please show me an example(template or anything), I'm a bit confused 😅

@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@praveen8ae praveen8ae closed this by deleting the head repository Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

var
5 participants