-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex maths functions #21539
Complex maths functions #21539
Changes from 15 commits
9dd84f6
75aa6c1
20680cc
93dc7db
2841ca2
0de9919
cada95d
cab0691
d705b2f
f7be90d
38be825
c7ab3b5
ee7370d
6e5710b
96daad1
fb463b3
36cefa6
78f158b
d61dca1
1e06ede
f661929
0de40cc
af62ab9
7f53dc5
7ce8343
e182d4f
3cc05de
a6e228b
3ec9bda
71ad8cd
0cb8f29
ff03dcb
ad44032
3ed1e6c
a02efc1
d265bda
9aceb26
92347a4
e0947f4
a26fe2b
8ff6e71
8713949
641bed2
fe5ecf5
de3d93e
0a1f32f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you added only the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The other case relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simple clarification of what each mode means would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an explanation in the base function and I was trying to keep the array method docstrings as minimal as possible, I can definitely add it if that's preferred though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree with @MahmoudAshraf97, the parameter descriptions should ideally be the same as the functional one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. Would it be enough to add
See ``ivy.func_wrapper.handle_complex_input`` for more detail.
or should I put a description in directly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's completely fine to add "See
ivy.func_wrapper.handle_complex_input
for more detail.". The only thing is the parameter descriptions for theivy.tanh
function should be the same as the parameter descriptions for theivy.Array.tanh
method 😄