Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #19194

Closed
wants to merge 2 commits into from
Closed

Master #19194

wants to merge 2 commits into from

Conversation

AhmadAli016
Copy link

implemented paddle.nn.functional.elu #19193 from Add paddle.nn.functional.activation NN Activation Functions to Paddle Frontend #15050

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jul 10, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@ivy-seed ivy-seed added the Stale label Jul 24, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@hmahmood24
Copy link
Contributor

Hey @AhmadAli016, thanks a lot for the PR! However, looking more closely, it’s unclear how this PR would meaningfully contribute towards the project, because of the following points:

1.You haven't linked the sub-task issue(s) you are working on by commenting Close #<issue_number> on this PR. It seems like the issue you wanted to work was already reserved and is being worked on by someone else.
2. The PR lacks the tests for the frontend function as well.
3. The PR lacks the lint/formatting standards that we need to stick to. You can use pre-commit to run the lint checks before commiting so your PR auto-formats to align with the standards we need to adhere to. For reference, the lint tests are failing here.

With these points in mind, I’ve simply closed the PR for now 🙂

Please feel free to submit other PRs based on our Open Tasks after going through our Contributing and Deep Dive guides first.

Thanks!

@hmahmood24 hmahmood24 closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants