Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a sortOrder flag to sort by creation date on iOS #1090

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Adds a sortOrder flag to sort by creation date on iOS #1090

merged 2 commits into from
Aug 1, 2019

Conversation

migue1s
Copy link
Contributor

@migue1s migue1s commented Jul 31, 2019 •
edited
Loading

Adds support for ordering the photos by creation date (ascending or descending) on iOS. By default, it'll keep the behavior that's currently on the library, which is that sort order is unspecified.

Related issues:
#953

@ivpusic ivpusic merged commit 33fd526 into ivpusic:master Aug 1, 2019
@ivpusic
Copy link
Owner

ivpusic commented Aug 1, 2019

thanks!

L-Yeiser pushed a commit to L-Yeiser/react-native-image-crop-picker that referenced this pull request Aug 1, 2019
@migue1s @L-Yeiser
Adds a sortOrder flag to sort by creation date on iOS (ivpusic#1090)
0c6bc74 
* Adds a sortOrder flag to sort by creation date on iOS

* Removes extraneous sortOrder access
@migue1s migue1s mentioned this pull request Aug 2, 2019
Closed
ivpusic added a commit that referenced this pull request Sep 11, 2019
@ivpusic
Revert "Adds a sortOrder flag to sort by creation date on iOS (#1090)"
bc72e5b 
This reverts commit 33fd526.
@ivpusic
Copy link
Owner

ivpusic commented Sep 11, 2019 •
edited
Loading

@migue1s could you add support for this feature by using official latest version of QBImagePicker? original PR is reverted because it modifies local copy of QBImagePicker

@migue1s
Copy link
Contributor Author

migue1s commented Sep 11, 2019

Got it, thanks for the heads up @ivpusic . I'll do it in a few days probably.

@migue1s
Copy link
Contributor Author

migue1s commented Nov 14, 2019

@ivpusic It seems like someone already did this on the official library on nek023/QBImagePicker#195 back in 2017. However, that lib hasn't been updated for 4 years and seems stale, does it still make sense to do the change on the original lib even when the maintainers seem to not be active?

adylevy pushed a commit to Homeisapp/react-native-image-crop-picker that referenced this pull request Nov 19, 2019
merge latest code (#11)
887e682 
* Add chooseText and cancelText properties: rebased (ivpusic#699)

* Add cancel and choose buttons text properties

* Change props names to ‘cancelText’,’chooseText’

* Add cancel and choose buttons text props

* Fix properties names IOS

* Add cropper prefix and update readme

* Add cloud support (Android) (ivpusic#650)

* Add cloud support - workd in progress

* Fix extension issue

* Remove log, unused import

* Fix regression (MIME_TYPE for action_get_document)

* (android) Upgrade ucrop to 2.2.2. Upgrade react-native for example project. Cleanup picker module

* version bump

* (android) Result collector improvements

* version bump

* Update README.md

* Update README.md

* Update README.md

* Reduce size of default compressed files, update README (ivpusic#736)

* [fix/android] Android API version under 19 crash fix (ivpusic#741)

* Convert unknown file types to JPEG (ivpusic#735)

* Added android equivalent code to iOS code. (ivpusic#749)

* Revert "Added android equivalent code to iOS code. (ivpusic#749)" (ivpusic#750)

This reverts commit 97ce8ba.

* Added android equivalent code for skipping image compression. (ivpusic#753)

* Added android equivalent code to iOS code.

* Fix invalid variable.

* Added option to configure avoidEmptySpaceAroundImage (ivpusic#765)

* Added option to configure avoidEmptySpaceAround image

* Added missing interface option

* Fixes uncasted bool value

* Add new logo/icon (ivpusic#768)

* Upload new logo

* Add new logo to README

* Add new to mipmap hdpi

* Add new to mipmap mdpi

* Add new to mipmap mdpi

* Add new to mipmap mdpi

* add new to mipmap mdpi

* Add new to mipmap mdpi

* Add new to mipmap mdpi

* Add new to mipmap mdpi

* Add new to mipmap xhdpi

* Add new to mipmap xhdpi

* Add new to mipmap xhdpi

* Add new to mipmap xhdpi

* Add new to mipmap xxhdpi

* Add new to mipmap xxhdpi

* Add new to mipmap xxhdpi

* Add new to mipmap xxhdpi

* Add new to mipmap xxhdpi

* Add new to mipmap xxhdpi

* Add new to mipmap xxhdpi

* Upload new logo svg

* Update README with new logo

* delete

* Upload New logo svg

* Update README

* Update README.md

* Use project-wide properties and new dependency (ivpusic#771)

* Support for gradle 3.+

* Add cropperToolbarTitle into TypeScript typings (ivpusic#777)

* Fix a bug when the file name contains slashes. (ivpusic#775)

It can happen when selecting an image downloaded from Weibo app.

* Change screen orientation so android will detect and change to match screen fixes issue ivpusic#733 (ivpusic#766)

* Adds forceJpg flag to convert live photos (ivpusic#791)

* Adds property to filter live photos

* Force JPG image conversion

* Renames forceJPG -> forceJpg

* [DEVOPS] version bump

* Revert to compile (ivpusic#796)

* [DEVOPS] Version bump

* add license scan

* Set options.networkAccessAllowed = YES in getVideoAsset to prevent freezing when attempting to get videos stored in the cloud (ivpusic#772)

* Fix typo on example (ivpusic#809)

* Fall back to writing to file if _data column does not exist (ivpusic#817)

* Fall back to writting to file if _data column does not exist

* Fix spelling

* Update README.md

* Update README.md (ivpusic#826)

Add optional configuration details about default ios text button for the camera and the gallery

* Diegolmello master (ivpusic#834)

* [FIX] Poor image quality after cropping

* Update README.md (ivpusic#826)

Add optional configuration details about default ios text button for the camera and the gallery

* [IMPROVEMENT] fix android cropping height condition. update podfile lock

* version bump

* Update README.md (ivpusic#851)

* Update PickerModule.java (ivpusic#862)

Fix for default values being kept when calling cropPicker from multiple locations.

Now default values if not passed will be reverted to default.

* version bump

* Add front camera support for android (ivpusic#876)

* Add front camera support for android

* Update readme

* Update readme

* Update README.md

* Added missing flags to support front camera on some android phones (ivpusic#891)

* Remove problematic step from manual post-install steps (ivpusic#821)

* (ios) fix images are not resized after cropping. Fixes ivpusic#843

* (ios) add example project xcshareddata

* (feature) video recording (ivpusic#917)

* Android: Add video recording support

- Caveats:
  - Wont work if cropping is enabled
- Video recording will be used if mediaType is set to 'video'
  - Mediatype any is not supported since there is no standard intent for capture image or video

* IOS: Add video recording support

- Caveats:
  - Cropping does not work

Video recording will be enabled if mediaType is set to `video` or `any`. Note: With any the native ui
allows the user to choose whether to take a photo or record a video. This differs from android where
mediaType any will just allow taking photos.

* IOS: Set camera video quality to high

* Update README.md (ivpusic#851)

* Update PickerModule.java (ivpusic#862)

Fix for default values being kept when calling cropPicker from multiple locations.

Now default values if not passed will be reverted to default.

* version bump

* Add front camera support for android (ivpusic#876)

* Add front camera support for android

* Update readme

* Update readme

* Update README.md

* Added missing flags to support front camera on some android phones (ivpusic#891)

* Remove problematic step from manual post-install steps (ivpusic#821)

* (ios) fix images are not resized after cropping. Fixes ivpusic#843

* (ios) add example project xcshareddata

* (ios) fixes for camera recording. updated example project with camera recording. updated readme with camera recording

* unify ios and android camera response. Fixes ivpusic#872

* version bump

* Update README.md

* Simplify `includeBase64` (ivpusic#918)

If `image.data` is already base64 encoded string, why do we need this wrapper?
The proposed change worked for me on ios and android.

* Make example config valid json (ivpusic#927)

* (android) cropping and resizing improvements

* (android) simplify options parsing

* android libs and package.json version bump

* Remove images from npm bundle (ivpusic#960)

* upgrade example project to react-native 0.59

* fix ios camera with cropping not reject on cancel cropping (ivpusic#954)

* fix ios camera with cropping not reject on cancel cropping

* cancel properly from opencropper

* replace compile with implementation in build.gradle

* version bump

* Add some types for Image interface (ivpusic#973)

* (android) add showCropFrame option (ivpusic#972)

* Fix Android image rotation issue when compressing gallery and camera images (ivpusic#379) (ivpusic#986)

When using the image compression options, the returned resized image orientation differed from the original image. This caused selected images to often be rotated.

Original issue thread:
ivpusic#379

* version bump

* example project support for android 9

* fixed bug with iOS cancel button (ivpusic#1000)

* version bump

* autoclose inputstream when base64 image file (ivpusic#1040)

* Fix when Pictures directory is not existing on device (ivpusic#1027)

* Update pod dependency to support rn 0.60 (ivpusic#1019)

* Update pod dependency to support rn 0.60

* Update RNImageCropPicker.podspec

* update android support library to androidx (ivpusic#1048)

* Update PickerModule.java

* Update RealPathUtil.java

* Update AndroidManifest.xml

* finishing support for react-native 0.60

* add installation notes for react-native 0.60

* Clarify README.md (ivpusic#1065)

React Native 0.60 higher requires you to manually install the pods after auto linking

* Clarify README.md (ivpusic#1058) (ivpusic#1074)

Not all Android devices handle useFrontCamera

* Adds a sortOrder flag to sort by creation date on iOS (ivpusic#1090)

* Adds a sortOrder flag to sort by creation date on iOS

* Removes extraneous sortOrder access

* check permission before startCropping. Fix of ivpusic#957 (ivpusic#1095)

* version bump

* Revert "Adds a sortOrder flag to sort by creation date on iOS (ivpusic#1090)"

This reverts commit 33fd526.

* version bump

* fixed `jitpack.io` url in readme.md (ivpusic#1115)

* Added iOS 13 DarkMode for picker (ivpusic#1129)

* Update README.md

* version bump

* HOM-3770 fix merge issues

* HOM-3770 restore video compression utility
@danilobuerger
Copy link
Contributor

@ivpusic QBImagePicker is not maintained anymore, I don't see how this can be added there.

habovh added a commit to allsquare/react-native-image-crop-picker that referenced this pull request Dec 17, 2019
@habovh
Revert "Revert "Adds a sortOrder flag to sort by creation date on iOS (…
f7be707 
…ivpusic#1090)""

This reverts commit bc72e5b.
@migue1s
Copy link
Contributor Author

migue1s commented Dec 26, 2019

Echoing what Danilo said, any way to go forward with this considering that the QBImagePicker isn't being maintained @ivpusic ?

@ivpusic
Copy link
Owner

ivpusic commented Dec 26, 2019

@migue1s could you reopen PR

@migue1s
Copy link
Contributor Author

migue1s commented Dec 31, 2019 •
edited
Loading

It doesn't work as expected anymore, due to the dependency being sourced from cocoapods now instead of using the embedded one (from the RN 60 changes). I'll contact the folks over at QuestBeat and see if we can get a couple of PRs merged in there + submit a couple fixes afterwards

@migue1s
Copy link
Contributor Author

migue1s commented Jan 9, 2020

@ivpusic QuestBeat is unfortunately not responding :( I think the only paths forward are:

in the short term people can use #1087 (comment) to fix their environments

in the long term we should fork + republish the lib to make it accessible via cocoapods or completely deintegrate the lib from the cocoapod dependencies and rely on the one inside the repo only (I tried doing a PR with the latter solution but I got stuck with some linker issues).

onedevlad pushed a commit to bloomapi/react-native-image-crop-picker that referenced this pull request Jan 15, 2020
Revert "Revert "Adds a sortOrder flag to sort by creation date on iOS (…
afe947c 
…ivpusic#1090)""

This reverts commit bc72e5b.
onedevlad pushed a commit to bloomapi/react-native-image-crop-picker that referenced this pull request Jan 15, 2020
Revert "Revert "Adds a sortOrder flag to sort by creation date on iOS (…
2e24ffe 
…ivpusic#1090)""

This reverts commit bc72e5b.
@ivpusic
Copy link
Owner

ivpusic commented Jan 19, 2020

added in version 0.27.0 https://github.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.27.0

@cspicuzza
Copy link

Thanks for adding this feature. Unfortunately it's not building with RN 0.6.5

The following build commands failed:
	CompileC {**projectpath**}/ios/build/Carbon/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RNImageCropPicker.build/Objects-normal/x86_64/ImageCropPicker.o {**projectpath**}/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

in attempts to troubleshoot I tried:

  • removing/installing node_modules
  • removing ios/build

@ivpusic
Copy link
Owner

ivpusic commented Jan 21, 2020 •
edited
Loading

you have to add

pod 'QBImagePickerController', :path => '../node_modules/react-native-image-crop-picker/ios/QBImagePicker/QBImagePickerController.podspec'

to your Podfile and after that run pod install

@Gavsum
Copy link

Gavsum commented Jan 22, 2020

you have to add

pod 'QBImagePickerController', :path => '../node_modules/react-native-image-crop-picker/ios/QBImagePicker/QBImagePickerController.podspec'

to your Podfile and after that run pod install

This is causing No known class method for selector 'labelColor' on build, any ideas ?

@migue1s
Copy link
Contributor Author

migue1s commented Jan 23, 2020

I have a feeling that your issue might be related to #1175 @Gavsum (haven't tried it yet though!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@migue1s @ivpusic @danilobuerger @cspicuzza @Gavsum