Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial implementation of build and deployment workflow #7

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Add initial implementation of build and deployment workflow #7

merged 6 commits into from
Mar 5, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Feb 26, 2024 •
edited
Loading

This workflow has the following features:

  • Builds and deploys the website using hugo
  • When running the action as a PR check, a dry run will be performed on the deployment step.
  • The build and deployment action can be manually triggered in the GH actions panel.
  • Account and directory information from @molinaro-m is used for the upload.

I don't actually know if the deployment works with the supplied username and target directory - it needs to be tested in GH actions.

@JeremyMcCormick
Set a variable for dry run of deployment
bbd0bf0 
If the action is running as part of a PR check, the deployment will be
a dry run.
@JeremyMcCormick
Correct parameter name for server
5bdc4f6
molinaro-m
molinaro-m approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow looks fine for me.
Let's try it.

@KlaasYK
Copy link
Collaborator

KlaasYK commented Mar 5, 2024

Looks good to me, let's get that merged 🚀

@KlaasYK KlaasYK self-requested a review March 5, 2024 08:18
@JeremyMcCormick
Copy link
Collaborator Author

I'll merge this tomorrow after I make a minor change to .gitignore

@JeremyMcCormick JeremyMcCormick merged commit 743210a into main Mar 5, 2024
1 check passed
@JeremyMcCormick JeremyMcCormick mentioned this pull request Mar 13, 2024
Closed
4 tasks
@JeremyMcCormick JeremyMcCormick deleted the iss4 branch May 19, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molinaro-m molinaro-m molinaro-m approved these changes

@KlaasYK KlaasYK KlaasYK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeremyMcCormick @KlaasYK @molinaro-m