Hopefully uncontroversial changes from the DAL review feedback

[jd-au]

No description provided.

[mbtaylor]

Somebody else sanity check this for me, but I believe that the original text atan2(y,x) is correct (i.e. the conventional order) and the suggested change to atan2(x,y) is wrong. See e.g. https://www.postgresql.org/docs/8.3/functions-math.html; also e.g.

select top 1 atan2(1,sqrt(3)) as pi_over_six from tap_schema.tables

from GAVO DC gives me PI/6 not PI/3. The same order is used for atan2 in other languages as well (java, python).

[jd-au]

Thanks for picking that up. I have reverted the atan2 change.

[msdemlei]

On Tue, Oct 10, 2023 at 04:14:08AM -0700, Mark Taylor wrote: Somebody else sanity check this for me, but I believe that the original text `atan2(y,x)` is correct (i.e. the conventional order)

FWIW, Mark's objection seems entirely sane to me, too.