Reword Preferred Crossmatch Syntax text to cover cone search too #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it explicit that the DISTANCE<limit idiom should be used for cone-search-like constraints as well as sky crossmatch-like constraints. This addresses the third point from the Ops IG RFC comments, see https://wiki.ivoa.net/twiki/bin/view/IVOA/ADQL21RFC#Operations%20Interest%20Group
gmantele
previously approved these changes
Aug 8, 2023
ADQL.tex
Outdated
| This section therefore recommends a preferred form of ADQL | ||
| to use for sky crossmatching and the related cone search operation, | ||
| namely to impose an upper limit on one of the two forms of the | ||
| DISTANCE operator. |
There was a problem hiding this comment.
I would have rather said DISTANCE function instead of DISTANCE operator.
Use term "function" rather than "operator" for DISTANCE; add "sky" in section title; use "<=" as well as "<" in examples.
gmantele
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it explicit that the DISTANCE<limit idiom should be used for cone-search-like constraints as well as sky crossmatch-like constraints.
This addresses the third point from the Ops IG RFC comments, see https://wiki.ivoa.net/twiki/bin/view/IVOA/ADQL21RFC#Operations%20Interest%20Group