KFA Integration #38
Merged
KFA Integration #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- second parameter pada getenv tidak berfungsi sebagai default value, perlu ditambahkan handler ?: jika user tidak define variable di env
- define base url dan enpoint displit :
- pada master data - KFA hanya menggunakan base url + endpoint
- pada FHIR / Auth menggunakan base url + prefix ('oauth2/v1' | 'fhir-r4/v1') + endpoint
Boleh tlg disediakan Wiki-nya juga? |
There was a problem hiding this comment.
Untuk OAuthClient yg diganti apakah bisa diupdate juga di Wiki @yudistirasd ?
sekalian nanti dengan cara using package KFA...
Trims
|
Boleh pak
…On Sat, Apr 6, 2024, 10:24 Ivan William Harsono ***@***.***> wrote:
***@***.**** commented on this pull request.
Untuk OAuthClient yg diganti apakah bisa diupdate juga di Wiki
@yudistirasd <https://github.com/yudistirasd> ?
sekalian nanti dengan cara using package KFA...
Trims
—
Reply to this email directly, view it on GitHub
<#38 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7YRZST63JWYCUGMX5EEMTY35TG3AVCNFSM6AAAAABF2CUUMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBUGQZTEMRWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31
perlu disediakan wiki tidak pak @ivanwilliammd ?
jika iya, contributenya bagaimana?