-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding feature to dismiss when pan on UIScrollView with UIStackView #77
base: master
Are you sure you want to change the base?
Conversation
Hi! Thanks! You can describe bug which you fix? How see it bug? |
For example, If you create a ViewController with a UITableView / UIScrollView ... top left right and bottom constraints 0 and it has a content size height greater than superview with bounce enabled, now if you reach the top when scroll the View didn't dismiss So this feature is to add the dismiss behavior in that case. |
@ivanvorobei What do you think about this pull request? |
@Tavernari I think you did the right job, but I need time to check how this will change the job. I can get it in a couple of days. |
@Tavernari I tried to create an empty project according to your description and reproduce the problem, but I did not succeed. Can you make an empty project with this problem? |
@ivanvorobei my situation is happening because I am using UIScrollView + UIStackView, so I will try to repeat that situation in an empty project and then I will send you to check... thanks for your time |
@Tavernari any news? |
Any updates on this? I am having a similar situation if I present a navigation controller, I saw on different threads this is known to cause issues but was trying to make it work for my situation. |
Hi, first of all, I have to say that your project is fantastic and works so smoothly.
This pull request is about to add a new feature, and this feature is about to dismiss this view using the pan on UIScrollView.
I hope it can help others with the same problem.