Update Kemal to 1.6.0 and remove Kilt #5120
Open
+9
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
added
the
need-testing
Kilt is unmaintained and the ECR templating logic has been natively integrated into Kemal with the issues previously seen having been resolved. This commit is mostly a precursor to support the next Kemal release which will add the ability to create error handlers for raised exceptions. See kemalcr/kemal#688
syeopite
force-pushed
the
update-kemal
branch
from
c2a5e2b to
3dc4054
Compare
|
Looks like we'll need to drop support for Crystal versions prior to |
|
I recall that we had a lot of templating issues when Kemal removed kilt. Even though it uses the stdlib's Btw, your addition of error handlers to Kemal is very cool :) |
|
Yeah those templating issues seem to have been resolved. On my side I didn't notice any problems during testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kilt is unmaintained and the ECR templating logic has been natively integrated into Kemal with the issues previously seen having been resolved.
This commit is mostly a precursor to support the next Kemal release which will add the ability to create error handlers for raised exceptions.
See kemalcr/kemal#688