Logger: Add color support for different log levels #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fijxu
requested review from
TheFrenchGhosty,
SamantazFox,
unixfox and
a team
as code owners
syeopite
approved these changes
Sep 20, 2024
syeopite
added
the
need-testing
|
Done, I also added information about the
|
|
I don't think it's a good idea to have this as enabled by default. I can see the color messing up with some existing log parsing system or something like that. |
Yeah you are right. This could break some automation system that does not support ANSI escape codes. It's better to leave it off by default and it would be great to point it on the wiki that this could be turned on (probably because most people would like to leave this setting on) if you want. |
SamantazFox
reviewed
Oct 7, 2024
SamantazFox
reviewed
Oct 7, 2024
SamantazFox
added
in-testing
SamantazFox
approved these changes
Oct 29, 2024
SamantazFox
added
ready
and removed
in-testing
|
I forgot to say thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this:
As I said in the code, this is useful when debugging things in Invidious. Having to find the type of error just by the name of the log level is not comfortable in my opinion.
Feel free to edit anything.