Use make_client instead of calling HTTP::Client
#4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
reviewed
Jun 16, 2024
SamantazFox
reviewed
Jun 16, 2024
This was referenced Jun 16, 2024
Merged
SamantazFox
reviewed
Aug 24, 2024
SamantazFox
reviewed
Aug 24, 2024
Using `make_client` to create `HTTP::Client`, allows for a simple way to easily add logic to all `HTTP::Client` initialized within Invidious.
Co-authored-by: ChunkyProgrammer <[email protected]>
Co-authored-by: Samantaz Fox <[email protected]>
syeopite
force-pushed
the
use-make-client
branch
from
4b8c6ea
to
6e39b9b
Compare
syeopite
commented
Aug 25, 2024
SamantazFox
approved these changes
Aug 25, 2024
SamantazFox
added
the
need-testing
SamantazFox
added
in-testing
SamantazFox
added
ready
and removed
in-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly so that we can customize the client Invidious uses for all HTTP requests. For example, to config a HTTP proxy to use.
I left
images.cruntouched as to not conflict with #4326