Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify code, use format!, more idiomatic code #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RisaI
Copy link

@RisaI RisaI commented Sep 26, 2024

Attempt to simplify the existing code and to use more idiomatic code, without changing the semantics.

  • Use format! macro instead of appending to a mutable String::new()
  • Add strum to derive Display and FromRepr for JobOpcode automatically
  • Implement Default for PlayerInfo
  • Satisfy clippy lints
  • Fix some typos in comments and logs
  • Remove duplicate state cloning code in process_socket

@unixfox unixfox requested a review from techmetx11 September 30, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant