-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add wakes-reforged client mod to the cf excludes #3443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
After #3436 pointed me to the right direction to make "Holycube Revolution" (https://www.curseforge.com/minecraft/modpacks/holycube-revolution) work, I kept going and noticed that those two files needed to be ignored. I also noticed smithing-template-viewer needed to be ignored, but it is already in the list ? Is it because the latest docker image does not contain the the latest changes to that list ? |
It successfully got built and published https://github.com/itzg/docker-minecraft-server/actions/runs/14906544497 You will need to re-pull that image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your editor seems to have changed every line of the file. Perhaps a whitespace change. Please revert and only make the line addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure why its not working now, I tried to do it without formatting, but its not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it might be a line endings difference.
https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings
In any case, I could do a separate PR to add that entry if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the new entry. could append it into mine too tomorrow evening
No description provided.