Skip to content

Add wakes-reforged client mod to the cf excludes #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JustSxm
Copy link

@JustSxm JustSxm commented May 12, 2025

No description provided.

@JustSxm
Copy link
Author

JustSxm commented May 12, 2025

After #3436 pointed me to the right direction to make "Holycube Revolution" (https://www.curseforge.com/minecraft/modpacks/holycube-revolution) work, I kept going and noticed that those two files needed to be ignored.

I also noticed smithing-template-viewer needed to be ignored, but it is already in the list ?

Is it because the latest docker image does not contain the the latest changes to that list ?

@itzg
Copy link
Owner

itzg commented May 12, 2025

It successfully got built and published

https://github.com/itzg/docker-minecraft-server/actions/runs/14906544497

You will need to re-pull that image.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your editor seems to have changed every line of the file. Perhaps a whitespace change. Please revert and only make the line addition.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure why its not working now, I tried to do it without formatting, but its not working

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it might be a line endings difference.

https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings

In any case, I could do a separate PR to add that entry if you want.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the new entry. could append it into mine too tomorrow evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants