[FIX] POS order return impossible (pos_orderline_absolute_discount) #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-mundo
changed the title
yelizariev
reviewed
Sep 15, 2022
| @@ -62,12 +62,13 @@ def _compute_amount_line_all(self): | |||
| product=line.product_id, | |||
| partner=line.order_id.partner_id, | |||
| ) | |||
| line.update( | |||
| res.update( | |||
There was a problem hiding this comment.
it should be line I think
|
thanks @yelizariev , we're going to have a look to this with @gaelTorrecillas |
|
I think we can close this one because it was not totally correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is a pull request to validate an article return with or without "absolute_discount".
At the beginning the return of article was possible only when there was an absolute_discount (discount by number, not percentage).
Now there is the return no matter what.
I tested it in all possibilities, from ticket to invoice.
Thanks