Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichannel grabber #260

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

Multichannel grabber #260

wants to merge 86 commits into from

Conversation

photoniker
Copy link
Contributor

@photoniker photoniker commented Jun 10, 2023

  • add demo
  • add meta information for plugin dataobject m_data
    image (liveImage of DummyGrabber)
  • add Gaussian spot to DummyMultiChannelGrabber
  • add meta information to DummyMultiChannelGrabber dataobject
  • adapt snapshot tool to DummyMultiChannelGrabber
  • adapt meta information during liveImage (Current close/re-open liveImage is necessary)
  • adapt configDialog, dockWidget of DummyGrabber and DummyMultiChannelGrabber
  • camera.setParam("roi[2]", 400) does not work for the multichannelgrabber
  • close issue ito::DObjMeta allowedTypes is wrongly implemented: Fix with next AddInInterface increment #187 after increment AddInInterface
  • merge Plugins PR
  • merge Designer PR
  • getParamListInfo() return as last elemente none
    image
  • Return 3d dataobject with number of planes as Channels?
  • addInMultiChannelGrabber.h should be restructured with a private class using the d_ptr structure, such that modifications, that will probably occur at some time, can be done without the need to change the binary compatibility. Appendix: AddInMultiChannelGrabber has a private class, but its nested struct ChannelContainer should be moved as good as possible into any cpp file.
  • extend documentation about standards and ideas behind AddInMultiChannelGrabber
  • we should check, if defaultChannel should be used both for settings the default, initially displayed channel, for any newly opened plot of a multigrabber plugin AND for the channel, to which the current parameters belong to, or if we should divide this into two parameters defaultChannel and channelSelector.

gegelle and others added 30 commits May 15, 2020 16:32
…rameters between the channels and m_params. SetParam set to final and a pure virtual function setParameter is added. SetParameter is called by setParam. If successful, setParameter must return ok. If parameter in setParameter could not be processed, setParam tries to process the parameter further.
…hanges in m_params to the channel params. Further improved setParam...
# Conflicts:
#	CMakeLists.txt
… via parameter suffixes. Additionally getParam was moved to AddInMultiChannelGrabber. getParam calls getParameter in the plugin to allow more specific handling in the plugin. This is analogous to setParam and setParameter respectively.
# Conflicts:
#	python_unittests/run_suite.py
…r.h. Started the implementation of initializeDefaultConfiguration. The QMap<QString,QStringList>m_paramChannelAvailabilityMap has been introduced. This map gives an overview which parameters are available for which channels. Todo: find a better name for the parameter.
@photoniker photoniker added the enhancement New feature or request label Jun 20, 2023
@photoniker photoniker added this to the v5.0 milestone Jun 21, 2023
@magro11
Copy link
Contributor

magro11 commented Jun 25, 2023

Further todos:

  • addInMultiChannelGrabber.h should be restructured with a private class using the d_ptr structure, such that modifications, that will probably occur at some time, can be done without the need to change the binary compatibility. Appendix: AddInMultiChannelGrabber has a private class, but its nested struct ChannelContainer should be moved as good as possible into any cpp file.
  • extend documentation about standards and ideas behind AddInMultiChannelGrabber
  • we should check, if defaultChannel should be used both for settings the default, initially displayed channel, for any newly opened plot of a multigrabber plugin AND for the channel, to which the current parameters belong to, or if we should divide this into two parameters defaultChannel and channelSelector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants