This repository has been archived by the owner on Apr 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor backend for TCN compliance #12
Open
rettetdemdativ
wants to merge
49
commits into
master
Choose a base branch
from
tcn-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rettetdemdativ
commented
Apr 10, 2020
- Merge upload and download APIs
- Add required functions instead of seemingly random ones
- Remove unnecessary clutter
flask_pymongo was causing problems because it automatically connects to mongoDB on localhost and ignored any URI passed to it. Also it features an older version of pymongo, which is totally unnecessary.
Install mongodb in actions pipeline
After considering the consequences of returning an error (clients could check which IDs already exist), we decided to do nothing if a duplicate exists
Handle duplicate reportsigs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.