Hotfix/memory usage #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
reviewed
Oct 25, 2023
Comment on lines
+3
to
+6
| # This do not work when running through docker compose exec. | ||
| # It defaults to /home/deploy and not the working dir. | ||
| # | ||
| #dir=$(cd $(dirname "${BASH_SOURCE[0]}") && pwd) |
There was a problem hiding this comment.
How and where does this not evaluate to /app/bin when run with docker compose exec?
I assume it's run as docker compose --file docker-compose.server.yml exec phpfpm bin/read-all-feeds and in this case the working directory must be /app (otherwise bin/read-all-feeds does not exist).
There was a problem hiding this comment.
See the servers cron job where it executes from.
It returns no-such-file /home/deploy/console @rimi-itk so the old way don't default to /app/bin as not bash context have been loaded...
turegjorup
approved these changes
Oct 26, 2023
cableman
force-pushed
the
hotfix/memory-usage
branch
from
05acfdf
to
0b2f8fb
Compare
rimi-itk
requested changes
Oct 26, 2023
| #dir=$(cd $(dirname "${BASH_SOURCE[0]}") && pwd) | ||
| # | ||
| # So for now lets assume we always are inside an ITKDev docker cotainer. | ||
| dir=/app/bin |
There was a problem hiding this comment.
Suggested change
| dir=/app/bin | |
| dir=$(cd $(dirname "$0") && pwd) |
or
Suggested change
| dir=/app/bin | |
| # @see https://stackoverflow.com/a/1638397 | |
| dir=$(cd $(dirname "$(readlink -f "$0")") && pwd) |
martinyde
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://jira.itkdev.dk/browse/SUPP0RT-1261 and https://jira.itkdev.dk/browse/SUPP0RT-1264
Description
When symfony commands do not complete the changes to the database is not commited to the database.
Screenshot of the result
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
N/A