BOOKING-265: Upgraded to latest Symfony #103
Conversation
| findUnusedBaselineEntry="true" | ||
| findUnusedCode="false" |
There was a problem hiding this comment.
These would probably be useful – if they work …
There was a problem hiding this comment.
I ran into this issue: psalm/psalm-plugin-symfony#151
migrations/Version20230810091726.php
Outdated
There was a problem hiding this comment.
I'm not sure we should have migrations for the messenger_messages table which, by default, is managed outside the migrations show, cf. https://symfony.com/doc/current/messenger.html#doctrine-transport. Anyway, we need some configuration to either use migrations for it (auto_setup: false) or ignore the table in migrations.
There was a problem hiding this comment.
Have added auto_setup: false
| * @param string $email | ||
| * @param string $type | ||
| * @param string $from | ||
| * @param string $to |
There was a problem hiding this comment.
I hate this kind of so-called documentation … But you're not to blame – blame society!
There was a problem hiding this comment.
I blame me. I could just remove the docblock instead of adding types :)
src/Entity/Resources/AAKResource.php
Outdated
| * @ORM\Entity | ||
| */ | ||
| class AAKResource | ||
| { | ||
| /** | ||
| * @Groups({"resource", "minimum"}) | ||
| * |
There was a problem hiding this comment.
Are these (almost) blank lines a result of updated coding standards or personal taste? I think they don't add any value, e.g. improved readability, and only make the files longer.
There was a problem hiding this comment.
Seems to be an issue with php-cs-fixer: PHP-CS-Fixer/PHP-CS-Fixer#6733
Have used solution from: PHP-CS-Fixer/PHP-CS-Fixer#6733 (comment)
… newlines between annotations
Link to ticket
https://jira.itkdev.dk/browse/BOOKING-265
Description
Upgraded to latest Symfony.
Checklist