Feature update: add credentials for IMAP

[haymaker]

I had a use case requiring separate credentials for IMAP - created a simple update to add credentials support.

Decided to keep it simple rather than add extra logic for cross-credential checking. If both sets of credentials are the same, they can just be duplicated.

DB version bumped to 0.6.2.

[github-actions]

Hello & Welcome! :)

Thanks for taking the time to help improve ITFlow. We're excited to review your contributions - we'll review this PR as soon as we can!

Whilst you're waiting, please feel free to check out the forum.

[wrongecho]

Test these changes at: https://imapcredentials702.pr-review.itflow.org
(automatic message)

[haymaker]

PR review link gives invalid credentials for demo@demo, tested against my local copy, no obvious issues, works as intended.

[wrongecho]

• Remove semi colon at end of query statement.

• Add update statement for database version

[wrongecho]

Hey! Welcome to ITFlow, it's great to have you here.

Firstly, thanks for the PR :) This was a feature we didn't add initially as we were going for MVP - it's great that you've taken the time to add it!

I'm not sure what happened with the PR Review instance, the users table was blank. I re-copied it across and it seems to work now. I'll look into it, but am low on time at the moment.

Just a couple of things to adjust, please - both in in database_updates.php:

1. The PR misses the line to update the database version - this causes the update database screen to just loop.

// Then, update the database to the next sequential version
mysqli_query($mysqli, "UPDATE `settings` SET `config_current_database_version` = '0.6.2'");

2. The second update statement in the PR has a semi-colon. I'm not sure if this breaks things or not (due to the looping above), but could we please remove for consistency's sake?

mysqli_query($mysqli, "ALTER TABLE `settings` ADD COLUMN `config_imap_password` VARCHAR(200) NULL DEFAULT NULL AFTER `config_imap_username`;");`

Could you please adjust the above and we'll take another look? Appreciate your time.

Cheers!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[haymaker]

Thanks for the reply! I'm not sure how this got missed - I swear I had this in my code prior to commit, so I have no idea how it disappeared. I remove the semicolon and re-added the version update statement.

Thank you!

Hey! Welcome to ITFlow, it's great to have you here.

Firstly, thanks for the PR :) This was a feature we didn't add initially as we were going for MVP - it's great that you've taken the time to add it!

I'm not sure what happened with the PR Review instance, the users table was blank. I re-copied it across and it seems to work now. I'll look into it, but am low on time at the moment.

Just a couple of things to adjust, please - both in in database_updates.php:

1. The PR misses the line to update the database version - this causes the update database screen to just loop.

// Then, update the database to the next sequential version
mysqli_query($mysqli, "UPDATE `settings` SET `config_current_database_version` = '0.6.2'");

2. The second update statement in the PR has a semi-colon. I'm not sure if this breaks things or not (due to the looping above), but could we please remove for consistency's sake?

mysqli_query($mysqli, "ALTER TABLE `settings` ADD COLUMN `config_imap_password` VARCHAR(200) NULL DEFAULT NULL AFTER `config_imap_username`;");`

Could you please adjust the above and we'll take another look? Appreciate your time.

Cheers!

[johnnyq]

nice work @haymaker i'll reel this one in tomorrow

[haymaker]

@johnnyq I'll see about getting some time to possibly contribute more, as I'm permitted. I'll look around at the forums/issues and see what I might be able to pick up and work on, keeping as close to the spirit of the code as I can for consistency's sake.

[johnnyq]

@haymaker That would be fantastic and were looking forward to working with you =]