Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic redirect to HTTPS #1032

Closed
wants to merge 2 commits into from
Closed

Conversation

k1ngErr0r
Copy link

Had an issue were - if user manually enters http in URL they get error.
Code change automatically redirects any http request to https - this should avoid the error.

Updating login.php to redirect http traffic to https;
If user manually enters http - change will pick up and auto redirect.
Updated portal login.php to redirect http traffic to https;
If end user manually enters http this will auto redirect and avoid error page.
Copy link

sonarcloud bot commented Sep 6, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello & Welcome! :)

Thanks for taking the time to help improve ITFlow. We're excited to review your contributions - we'll review this PR as soon as we can!

Whilst you're waiting, please feel free to check out the forum.

Just so you know, all contributions to ITFlow are licensed under the GNU GPL. By contributing you grant us a perpetual & irrevocable license to include your work in ITFlow.

@wrongecho
Copy link
Collaborator

Hey there @k1ngErr0r
Thanks for the PR.

We decided a while ago that this should be handled at the server level (Apache/Nginx) rather than within the app.

This is because you may have a perfectly valid reason to serve HTTP (e.g. Running ITFlow behind a forward proxy / load balancer that handles the SSL offloading).

@k1ngErr0r
Copy link
Author

Makes sense - change works for my case but would work behind forward proxy too.

Thanks :)

@k1ngErr0r k1ngErr0r closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants