Patch Studio API update timinig issue #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
patch-timing-issue
branch
from
f24c7f6
to
512b000
Compare
mattseddon
commented
Sep 5, 2023
| this.experiments.assumePushed(shas) | ||
| } | ||
|
|
||
| private waitForStudioUpdate() { |
There was a problem hiding this comment.
[F] I tried to combine the waitForStudioUpdate & waitForRemoteUpdate methods but the code was a lot harder to read.
mattseddon
commented
Sep 5, 2023
| } | ||
|
|
||
| const [, { lsRemoteOutput }] = await Promise.all([ | ||
| this.waitForStudioUpdate(), |
There was a problem hiding this comment.
[F] If we don't wait for this the assumePushed shas can be overwritten.
mattseddon
force-pushed
the
patch-timing-issue
branch
from
512b000
to
18b2e18
Compare
|
Code Climate has analyzed commit 18b2e18 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.9% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3574
After pushing an experiment there is a delay before it becomes available via the new Studio GET endpoint.
There were two possible solutions that came to mind.
I went with option 2 as option 1 seemed to be more brittle.
Demo
Screen.Recording.2023-09-05.at.12.34.34.pm.mov
Note: We can update this later if we run into issues. The code is clearly signposted.