Remove await from inside of loops #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2023
mattseddon
force-pushed
the
remove-loop-await
branch
from
be3f1b1
to
ad82da4
Compare
mattseddon
commented
Jul 26, 2023
| } | ||
|
|
||
| const branchLogs = await Promise.all(promises) | ||
| const { args, gitLog, rowOrder } = this.collectGitLogAndOrder(branchLogs) |
There was a problem hiding this comment.
[F] The order that we collect the information from the promises is important so we need to wait for them all to resolve before we can proceed. This should still give us a performance boost for a large number of branches.
mattseddon
force-pushed
the
remove-loop-await
branch
2 times, most recently
from
47603e2
to
ad5efcf
Compare
julieg18
approved these changes
Jul 26, 2023
mattseddon
force-pushed
the
improve-performance
branch
from
c36ed8e
to
0b99d2e
Compare
mattseddon
force-pushed
the
remove-loop-await
branch
from
ad5efcf
to
11cdce5
Compare
|
Code Climate has analyzed commit 11cdce5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/3
main<- #4346 <- #4353 <- thisI turned on eslint's no-await-in-loop and reviewed all instances case-by-case. Of the 30 or so instances of a rule violation, the two in this PR were the ones that stood out.