-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add not missing filter for experiments table #4308
Conversation
@@ -0,0 +1,271 @@ | |||
import { FilterDefinition, filterExperiment, Operator } from '.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] This file got purged in #3585. I brought it back/modified it to bring back some coverage.
@@ -21,6 +21,12 @@ export const OPERATORS = [ | |||
types: ['number', 'string'], | |||
value: Operator.NOT_EQUAL | |||
}, | |||
{ | |||
description: 'Not Missing', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would an antonym of missing make more sense? Like "Defined" or "Contains"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Missing"/"Missing values" is a Data Science term that most users will be familiar with.
No matter the answer is, I think it's a great option to have anyways. Let's go for it and show this to the user. Thanks @mattseddon ! |
068521b
to
834ccf4
Compare
Code Climate has analyzed commit 834ccf4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 85.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2%. View more on Code Climate. |
Related to #4269.
Could partly solve the third checkbox depending on the answer we get back from the user.
The additional filter can be used to exclude experiments that are missing a value for a column.
Demo
Screen.Recording.2023-07-19.at.4.21.36.pm.mov
Note: In the demo project I queued up an experiment and metrics are no longer missing. To be discussed with @shcheklein.