Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up hide column terminology #4304

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Clean up hide column terminology #4304

merged 1 commit into from
Jul 19, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 19, 2023

2/2 main <- #4303 <- this

When testing the previous PR I noticed that you can hide a column group using the "Hide Column" option. Decided this is a feature instead of a bug so cleaned up some of the terminology around the hide command.

Demo

Screen.Recording.2023-07-19.at.11.03.25.am.mov

@mattseddon mattseddon self-assigned this Jul 19, 2023
@mattseddon mattseddon changed the base branch from main to add-move-to-start July 19, 2023 01:11
@mattseddon mattseddon marked this pull request as ready for review July 19, 2023 01:12
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Base automatically changed from add-move-to-start to main July 19, 2023 22:27
@codeclimate
Copy link

codeclimate bot commented Jul 19, 2023

Code Climate has analyzed commit 7f51bfd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit bd32ced into main Jul 19, 2023
6 checks passed
@mattseddon mattseddon deleted the clean-hide-column branch July 19, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants