-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add columns indicator (select columns) to table indicators #4293
Conversation
@@ -1584,136 +1584,178 @@ describe('App', () => { | |||
expect(sortIndicator).toHaveTextContent('2') | |||
jest.useRealTimers() | |||
}) | |||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] The describe block shouldn't have ended here. I'll mark the new test(s).
expect(mockPostMessage).toHaveBeenCalledWith({ | ||
type: MessageFromWebviewType.FOCUS_FILTERS_TREE | ||
|
||
it('should show an indicator with the amount of displayed columns', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] last two tests are new
21b2a3c
to
07f8adb
Compare
@@ -123,6 +134,15 @@ export const Indicators = () => { | |||
> | |||
<Icon width={16} height={16} icon={GitMerge} /> | |||
</Indicator> | |||
<Indicator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] Considered making this the first indicator. Decided against it. Happy to update if you have a different opinion.
07f8adb
to
cca8860
Compare
Code Climate has analyzed commit cca8860 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Related to #4269 & #4229
This PR adds a columns indicator icon to the experiment table indicators. Clicking on the indicator icon will trigger the
Select Columns to Display in the Experiments Table
quick pick.Demo
Screen.Recording.2023-07-18.at.11.56.35.am.mov
Note: I am also planning to add a "Move Columns To Start" or "Move Columns Left" quick pick.