Exclude sub-project files from file and editor watchers #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jul 17, 2023
| for (const file of fileList) { | ||
| if (file.startsWith(this.dvcRoot)) { | ||
| if (isPathInProject(file, this.dvcRoot, this.subProjects)) { | ||
| this.collectedFiles.push(file) |
There was a problem hiding this comment.
[B] Not having collectedFiles for this class was actually a bug.
There was a problem hiding this comment.
discovered by writing a test for this functionality
mattseddon
force-pushed
the
handle-sub-projects
branch
from
3c6e67c
to
740ba9f
Compare
julieg18
approved these changes
Jul 17, 2023
mattseddon
force-pushed
the
handle-sub-projects
branch
from
03741d3
to
9158ead
Compare
|
Code Climate has analyzed commit fb4966a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 91.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some sub-project-related issues with our file system and editor watchers. We were previously not correctly excluding sub-project files from their parent project's watchers.