-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude sub-project files from file and editor watchers #4283
Conversation
for (const file of fileList) { | ||
if (file.startsWith(this.dvcRoot)) { | ||
if (isPathInProject(file, this.dvcRoot, this.subProjects)) { | ||
this.collectedFiles.push(file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[B] Not having collectedFiles
for this class was actually a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discovered by writing a test for this functionality
3c6e67c
to
740ba9f
Compare
03741d3
to
9158ead
Compare
Code Climate has analyzed commit fb4966a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 91.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1%. View more on Code Climate. |
This PR fixes some sub-project-related issues with our file system and editor watchers. We were previously not correctly excluding sub-project files from their parent project's watchers.