Focus pipeline when dvc.yaml file is open in the active editor #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jul 14, 2023
| @@ -420,7 +420,8 @@ | |||
| { | |||
| "title": "Show Pipeline DAG", | |||
| "command": "dvc.showPipelineDAG", | |||
| "category": "DVC" | |||
| "category": "DVC", | |||
| "icon": "$(symbol-class)" | |||
There was a problem hiding this comment.
I am open to suggestions for a different codicon.
mattseddon
force-pushed
the
focus-pipeline
branch
from
bddcf20
to
82667e6
Compare
mattseddon
commented
Jul 14, 2023
| setActiveEditorContext(path) | ||
| }) | ||
|
|
||
| export const setContextForEditorTitleIcons = ( |
There was a problem hiding this comment.
[F] this code is close to what we do for experiments.
mattseddon
force-pushed
the
rewrite-getter-stub
branch
from
664987e
to
7778d1f
Compare
mattseddon
force-pushed
the
focus-pipeline
branch
from
82667e6
to
7a626c7
Compare
|
Code Climate has analyzed commit 7a626c7 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 92.8% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/3
main<- #4264 <- #4272 <- thisThis PR focuses a pipeline when the respective
dvc.yamlfile is open in the active editor.This means that we can add the
Show Pipeline DAGcommand to the editor/title and bypass showing a choice of pipelines to the user if they choose to run an experiment with advc.yamlfile open.Demo
Screen.Recording.2023-07-14.at.1.36.41.pm.mov
PR needs tests.