-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus pipeline when dvc.yaml file is open in the active editor #4273
Conversation
@@ -420,7 +420,8 @@ | |||
{ | |||
"title": "Show Pipeline DAG", | |||
"command": "dvc.showPipelineDAG", | |||
"category": "DVC" | |||
"category": "DVC", | |||
"icon": "$(symbol-class)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am open to suggestions for a different codicon.
bddcf20
to
82667e6
Compare
setActiveEditorContext(path) | ||
}) | ||
|
||
export const setContextForEditorTitleIcons = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] this code is close to what we do for experiments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
664987e
to
7778d1f
Compare
82667e6
to
7a626c7
Compare
Code Climate has analyzed commit 7a626c7 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 92.8% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.1% change). View more on Code Climate. |
3/3
main
<- #4264 <- #4272 <- thisThis PR focuses a pipeline when the respective
dvc.yaml
file is open in the active editor.This means that we can add the
Show Pipeline DAG
command to the editor/title and bypass showing a choice of pipelines to the user if they choose to run an experiment with advc.yaml
file open.Demo
Screen.Recording.2023-07-14.at.1.36.41.pm.mov
PR needs tests.