Remove dvc_data_version_info from plot values
#4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
changed the title
dvc_data_version_info from export plot datadvc_data_version_info from plot values
julieg18
force-pushed
the
rm-dvc-data-version-info-from-export-data
branch
from
65f0517
to
e540fb7
Compare
|
Code Climate has analyzed commit 1fefeb6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
julieg18
commented
Jul 18, 2023
| ...value, | ||
| ...dvc_data_version_info, | ||
| rev | ||
| } | ||
|
|
||
| if (hasKey(data, 'dvc_data_version_info')) { | ||
| delete data.dvc_data_version_info |
There was a problem hiding this comment.
Looking at the code, revisionData is only used for template plots, so should be safe to delete the key here. But please let me know if I missed something or if there is a better spot.
mattseddon
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Screen.Recording.2023-07-17.at.8.31.28.PM.mov
Part of #4246