Implement simple onDefinition feature in LSP #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
fix-on-definition
branch
from
f72b0e5 to
0f58ceb
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
force-pushed
the
fix-on-definition
branch
from
4b33e2f to
47b45f2
Compare
mattseddon
force-pushed
the
fix-on-definition
branch
from
47b45f2 to
4c433d9
Compare
sroy3
approved these changes
Jan 31, 2023
|
Code Climate has analyzed commit 737d9a8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.5% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
main<- this <- #3185Related to #2529
This PR reinstates the language server with a single piece of basic functionality. We now provide definitions for symbols within
dvc.yamlfiles. If the symbol relates to a file then we open that file in a text editor. The problem described here has been removed.Demo
Screen.Recording.2023-01-31.at.3.41.25.pm.mov