Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner docker volumes #367

Merged
merged 8 commits into from
Jan 17, 2022
Merged

Runner docker volumes #367

merged 8 commits into from
Jan 17, 2022

Conversation

DavidGOrtega
Copy link
Contributor

Counterpart of iterative/cml#861

resource "iterative_cml_runner" "runner" {
    provider = iterative2

    cloud     = "azure"
    region    = "us-east"
    instance_type = "Standard_D2S_v3"
    spot     = true

    driver  = "gitlab"
    repo    = "https://gitlab.com/DavidGOrtega/fashion_mnist"
    token   = "XXX"
    docker_volumes = [
        "/myfile:/myfile"
    ]
}

@DavidGOrtega DavidGOrtega requested a review from a team January 16, 2022 10:19
0x2b3bfa0
0x2b3bfa0 requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please escape shell arguments. 🔐

iterative/resource_runner.go Outdated Show resolved Hide resolved
DavidGOrtega and others added 2 commits January 17, 2022 11:09
@DavidGOrtega @0x2b3bfa0
escape
c7d78e7 
Co-authored-by: Helio Machado <[email protected]>
@DavidGOrtega
test escape
bcbb4c2
@0x2b3bfa0 0x2b3bfa0 merged commit e50ea79 into master Jan 17, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the runner-docker-volumes branch January 17, 2022 15:40
@casperdcl casperdcl mentioned this pull request Jan 21, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidGOrtega @0x2b3bfa0