Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match bash current word exactly instead of as regex #144

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Match bash current word exactly instead of as regex #144

merged 1 commit into from
Jul 28, 2023

Conversation

scop
Copy link
Contributor

@scop scop commented Jul 28, 2023

Matching as regex does not seem correct for these cases to me offhand.

@scop
Match bash current word exactly instead of as regex
b0f2e4a 
Matching as regex does not seem correct for these cases to me offhand.
casperdcl
casperdcl approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@casperdcl casperdcl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops; good spot 🦅👁️ - thanks!

@casperdcl casperdcl added enhancement New feature or request shell-bash external-request You asked, we did labels Jul 28, 2023
@casperdcl casperdcl merged commit 56beb5f into iterative:main Jul 28, 2023
4 checks passed
@casperdcl casperdcl added technical-debt Refactoring, linting & tidying and removed enhancement New feature or request labels Jul 28, 2023
@scop scop deleted the refactor/bash-no-regex branch July 28, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@scop scop

Labels
external-request You asked, we did shell-bash technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @casperdcl