Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy from 1.13.0 to 1.14.0 #854

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Bump mypy from 1.13.0 to 1.14.0 #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a5f804
Bump mypy from 1.13.0 to 1.14.0
dependabot[bot] Dec 23, 2024
e39826e
ignore double fabric imports
shcheklein Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ tests = [
]
dev = [
"dvclive[all,tests]",
"mypy==1.13.0",
"mypy==1.14.0",
"types-PyYAML"
]
mmcv = ["mmcv"]
Expand Down
2 changes: 1 addition & 1 deletion src/dvclive/fabric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
)
from lightning.fabric.utilities.rank_zero import rank_zero_only
except ImportError:
from lightning_fabric.loggers.logger import Logger, rank_zero_experiment
from lightning_fabric.loggers.logger import Logger, rank_zero_experiment # type: ignore[assignment]
from lightning_fabric.utilities.logger import (
_add_prefix,
_convert_params,
Expand Down
2 changes: 1 addition & 1 deletion src/dvclive/lightning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from lightning.pytorch.utilities import rank_zero_only
except ImportError:
from pytorch_lightning.callbacks.model_checkpoint import ModelCheckpoint # type: ignore[assignment]
from pytorch_lightning.loggers.logger import Logger
from pytorch_lightning.loggers.logger import Logger # type: ignore[assignment]
from pytorch_lightning.utilities import rank_zero_only

try:
Expand Down
Loading