Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pyproject): proper reference to the lighting extra #752

Closed
wants to merge 1 commit into from

Conversation

shcheklein
Copy link
Member

Found a small issue while reviewing #749


Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@shcheklein shcheklein self-assigned this Dec 9, 2023
@shcheklein shcheklein requested a review from dberenbaum December 9, 2023 22:33
@shcheklein shcheklein added the bug Did we break something? label Dec 9, 2023
@shcheklein
Copy link
Member Author

Actually, I think it's better to be fixed right in the #749 since we are changing the lighting module there and here CI fails with mypy on it.

@shcheklein shcheklein closed this Dec 9, 2023
@dberenbaum
Copy link
Collaborator

dberenbaum commented Dec 11, 2023

@shcheklein What issue did you hit using pytorch-lightning? The codebase tries to be compatible with both lightning and pytorch-lightning, so wondering if there is something we need to address here.

@shcheklein
Copy link
Member Author

I think the dvclive[all] just doesn't install it. Since there is not pytorch-lightning anymore AFAIR.

@dberenbaum
Copy link
Collaborator

Okay, I see. It looks like they both still exist but lightning is a superset that includes both pytorch-lightning and fabric. See Lightning-AI/pytorch-lightning#16688 (comment).

@shcheklein
Copy link
Member Author

shcheklein commented Dec 11, 2023

To clarify, I think it us:

tf = ["tensorflow"]
xgb = ["xgboost"]
lgbm = ["lightgbm"]
huggingface = ["transformers", "datasets"]
catalyst = ["catalyst>22"]
fastai = ["fastai"]
lightning = ["lightning>=2.0", "torch"]
optuna = ["optuna"]
all = [
   "dvclive[image,mmcv,tf,xgb,lgbm,huggingface,catalyst,fastai,lightning,optuna,plots,markdown]"
]

mind the lightning and it's definition. all was referring to non-existent extra in our config ASFAIU.

@shcheklein shcheklein deleted the fix-pyproject-all-extra-lighting branch December 11, 2023 20:53
@dberenbaum
Copy link
Collaborator

🀦 Got it, thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants