Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DVC for VS Code Extension sorting demo #4923

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Oct 16, 2023

  • As discussed in planning, adds a mention of sorting in the vscode extension to the docs

Demo

In /doc/command-reference/exp/show

https://github.com/iterative/dvc.org/assets/43496356/94663389-820d-485e-9982-c07ed3c6f7f8

image

In /doc/user-guide/experiment-management:

image

@julieg18 julieg18 self-assigned this Oct 16, 2023
@julieg18 julieg18 changed the title Add VS Code sorting demo Add DVC for VS Code Extension sorting demo Oct 16, 2023
@@ -281,6 +281,18 @@ $ dvc exp show --only-changed --sort-by=roc_auc --sort-order desc
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
```

<details>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another alternative place I considered was somewhere in https://dvc.org/doc/user-guide/experiment-management/comparing-experiments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not both? 😄 It's a very small addition, so I don't see much harm including it there also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated comparing-experiments.md as well!

image

@julieg18 julieg18 marked this pull request as ready for review October 16, 2023 15:49
@shcheklein shcheklein temporarily deployed to dvc-org-add-vscode-sort-qb78uj October 16, 2023 15:49 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Link Check Report

There were no links to check!

@julieg18 julieg18 temporarily deployed to dvc-org-add-vscode-sort-qb78uj October 16, 2023 21:59 Inactive
@julieg18
Copy link
Contributor Author

@dberenbaum, is this ready to merge or are there more changes needed?

Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @julieg18!

In the exp show page, can we move it above Paginating the output near the top right after the text below?

Experiments in the table are first grouped (by parent commit). They are then sorted inside each group, chronologically by default. The --sort-by and --sort-order options can change this ordering, based on any single, visible metric or param.

That will make it more visible.

@julieg18 julieg18 temporarily deployed to dvc-org-add-vscode-sort-qb78uj October 25, 2023 13:37 Inactive
@julieg18
Copy link
Contributor Author

In the exp show page, can we move it above Paginating the output near the top right after the text below?

Moved! Did you want to keep things wrapped in a details block? I removed it for now:

image

@julieg18 julieg18 temporarily deployed to dvc-org-add-vscode-sort-qb78uj October 25, 2023 13:43 Inactive
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @julieg18 !

@dberenbaum dberenbaum merged commit 82864bd into main Oct 25, 2023
5 checks passed
@dberenbaum dberenbaum deleted the add-vscode-sorting-demo branch October 25, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants