-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exp rename typo #4889
Fix exp rename typo #4889
Conversation
experiment Experiments to rename. | ||
name Name of new experiment. | ||
experiment Experiment to rename | ||
name Name of new experiment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just committed a suggestion to revert the change on this line, but was there a reason behind wanting to change it @mattseddon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the experiment is still the same, it just has a new name. It is not a new experiment
@mattseddon We should also change the CLI help text, although it's not critical. |
I'll raise a PR |
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Noticed this whilst looking at iterative/vscode-dvc#4616