Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvclive: Add YOLO page. #4742

Merged
merged 5 commits into from
Aug 8, 2023
Merged

dvclive: Add YOLO page. #4742

merged 5 commits into from
Aug 8, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Aug 4, 2023

@daavoo daavoo self-assigned this Aug 4, 2023
@daavoo daavoo added the C: dvclive Content of /doc/dvclive label Aug 4, 2023
@daavoo daavoo requested a review from a team August 4, 2023 15:23
@daavoo daavoo mentioned this pull request Aug 4, 2023
Merged
@shcheklein shcheklein temporarily deployed to dvc-org-yolo-notebook-qqppox1g August 4, 2023 15:26 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023 •
edited
Loading

Link Check Report

There were no links to check!

@dberenbaum

This comment was marked as resolved.

Sign in to view
@dberenbaum
Copy link
Collaborator

Should we link to https://docs.ultralytics.com/reference/utils/callbacks/dvc/ somewhere?

Also, can we show some example output and/or a summary of what gets logged?

@daavoo daavoo requested a review from a team as a code owner August 7, 2023 08:03
@shcheklein shcheklein temporarily deployed to dvc-org-yolo-notebook-qqppox1g August 7, 2023 08:03 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-yolo-notebook-qqppox1g August 7, 2023 08:23 Inactive
@daavoo daavoo requested a review from dberenbaum August 8, 2023 10:33
dberenbaum
dberenbaum approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Minor suggestion: mention that the screen shots are an example of outputs in Studio (users may not know how they can see those views, and it doesn't hurt to link to Studio).

@shcheklein shcheklein temporarily deployed to dvc-org-yolo-notebook-qqppox1g August 8, 2023 16:17 Inactive
@daavoo daavoo merged commit df8c072 into main Aug 8, 2023
2 checks passed
@daavoo daavoo deleted the yolo-notebook branch August 8, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@daavoo daavoo

Labels
C: dvclive Content of /doc/dvclive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daavoo @dberenbaum @shcheklein