Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: list/import/get: document --config/--remote/--remote-config #4722

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 24, 2023

Fixes #4712

@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk July 24, 2023 17:52 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Link Check Report

There were no links to check!

@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk July 29, 2023 01:31 Inactive
@dberenbaum
Copy link
Collaborator

From https://discord.com/channels/485586884165107732/1135946899011162203/1136125484019748995:

I wonder if the DVC (draft) documentation will address the different config files: config, config.local and custom config for remote registries in detail somewhere? Also worth having a description of how the local custom config gets merged with the registry's config.

@efiop efiop changed the title docs: list/import/fetch: document --config docs: list/import/get: document --config Aug 2, 2023
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 5, 2023 22:26 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 5, 2023 22:39 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 5, 2023 23:49 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 5, 2023 23:58 Inactive
@efiop
Copy link
Contributor Author

efiop commented Aug 6, 2023

From https://discord.com/channels/485586884165107732/1135946899011162203/1136125484019748995:

I wonder if the DVC (draft) documentation will address the different config files: config, config.local and custom config for remote registries in detail somewhere? Also worth having a description of how the local custom config gets merged with the registry's config.

The guy wanted only --remote, so I just added an example. Doesn't seem to be a reason to go too deep into config in this PR, maybe later on.

@efiop efiop marked this pull request as ready for review August 6, 2023 00:27
@efiop efiop changed the title docs: list/import/get: document --config docs: list/import/get: document --config/--remote/--remote-config Aug 6, 2023
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 6, 2023 19:19 Inactive
@shcheklein shcheklein had a problem deploying to dvc-org-fix-4712-t5jcnasayjnyk August 6, 2023 19:20 Failure
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 8, 2023 22:31 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 8, 2023 22:54 Inactive
@shcheklein shcheklein had a problem deploying to dvc-org-fix-4712-t5jcnasayjnyk August 8, 2023 22:56 Failure
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 8, 2023 23:08 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-fix-4712-t5jcnasayjnyk August 8, 2023 23:32 Inactive
@efiop
Copy link
Contributor Author

efiop commented Aug 8, 2023

Let's run with this and I'll do any adjustments on top. This is useful as is, so eager to put it out there. Thanks again for the review!

@efiop efiop merged commit aae9193 into main Aug 8, 2023
4 checks passed
@efiop efiop deleted the fix-4712 branch August 8, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls/import/get: document --config
3 participants