move functional tests out of unit test suite #832
Conversation
mattseddon
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 128 128
Lines 11377 11377
Branches 1547 1547
=======================================
Hits 9947 9947
Misses 1040 1040
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @pytest.mark.parametrize( | ||
| "cloud_type,version_aware", | ||
| [("s3", True)], | ||
| indirect=True, | ||
| ) | ||
| def test_convert_type(cloud_test_catalog): |
There was a problem hiding this comment.
This test looks like an unittest. Unrelated, but this probably does not s3 fixture (I am not asking you to fix this, just a drive-by comment).
| @@ -555,6 +556,23 @@ def test_mutate_existing_column(test_session): | |||
| assert list(ds.order_by("ids").collect()) == [(2,), (3,), (4,)] | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("processes", [False, 2, True]) | |||
| @pytest.mark.xdist_group(name="tmpfile") | |||
| def test_parallel(processes, test_session_tmpfile): | |||
There was a problem hiding this comment.
What was the reason to move this to func?
There was a problem hiding this comment.
Run time, the fact it is write to disk and the group it is in
| @@ -613,6 +631,36 @@ def name_len(name): | |||
| assert count == 7 | |||
|
|
|||
|
|
|||
| @pytest.mark.xdist_group(name="tmpfile") | |||
| def test_udf_parallel_boostrap(test_session_tmpfile): | |||
There was a problem hiding this comment.
Same question here: what was the reason to move this to func tests?
* move tests using cloud_test_catalog into func directory * move tests using tmpfile catalog * move long running tests that read/write from disk
closes #829
This PR moves functional tests from
tests/unitunderneathtests/func.When combined with the changes in #831 the total run time of the
tests/unit/libfolder is < 15 seconds (on my machine) as opposed to ~40 seconds formain.