-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor file system source and path #496
Conversation
Deploying datachain-documentation with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 87.49% 87.36% -0.14%
==========================================
Files 97 97
Lines 10122 10136 +14
Branches 1382 1386 +4
==========================================
- Hits 8856 8855 -1
- Misses 909 923 +14
- Partials 357 358 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Removing so many special cases for cloud_type == "file"
in the tests is nice!
e03ba1e
to
0864e6e
Compare
Before, when listing local FS, we had root of the FS always set for
source
field, e.gfile:///
and the rest was inpath
. Idea behind this was to utilize partial indexing and remove obsoleteadd_storage
method.Now, when we are moving away from partial and bucket tables and moving indexing / listing to application level, we don't need this kind of setup as it was not convenient or intuitive.
With this changes when someone does
DataStorage.from_storage("file:///home/ivan/animals/")
we will have something like this in the listing table:This also adds re-indexing check in
.from_storage()
to avoid re-indexing if not needed.Old code related to that root of the FS mentioned at beginning of description was removed.
Note that some tests were skipped as it was not possible to refactor them without diving deep into other important task that will be worked on soon as well: #318