Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

docs: Update GHA workflow timeout to 35 days #262

Merged
merged 3 commits into from
Jul 19, 2022
Merged

docs: Update GHA workflow timeout to 35 days #262

merged 3 commits into from
Jul 19, 2022

Conversation

danieljimeneznz
Copy link
Contributor

@danieljimeneznz danieljimeneznz commented Jun 18, 2022 •
edited
Loading

@casperdcl casperdcl self-requested a review June 20, 2022 08:41
@casperdcl casperdcl added external-request You asked, we did documentation Markdown files labels Jun 20, 2022
@casperdcl casperdcl mentioned this pull request Jun 20, 2022
Closed
3 tasks
@dacbd
Copy link
Contributor

dacbd commented Jul 7, 2022

When I was reading up on this change, I noticed that GitHub lists a 6 hr limit for a job and a 35 hr limit for an entire workflow, I couldn't find any information for a job limit applying to self-hosted runners.

Should we include a link back to the GitHub docs for the limits?

@danieljimeneznz
Copy link
Contributor Author

When I was reading up on this change, I noticed that GitHub lists a 6 hr limit for a job and a 35 hr limit for an entire workflow, I couldn't find any information for a job limit applying to self-hosted runners.

Should we include a link back to the GitHub docs for the limits?

What we've linked back to in the docs states the following:

Workflow run time - Each workflow run is limited to 35 days. If a workflow run reaches this limit, the workflow run is cancelled. This period includes execution duration, and time spent on waiting and approval.

casperdcl
casperdcl approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that iterative/cml#1067 is merged & released (cough), this should be merged too.

@casperdcl casperdcl merged commit 24a1aee into iterative:master Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@casperdcl casperdcl

@danieljimeneznz danieljimeneznz

Labels
documentation Markdown files external-request You asked, we did
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieljimeneznz @dacbd @casperdcl