Update to latest version of RN in example app #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msingleton
commented
Nov 19, 2023
| '&' | ||
| )}');`; | ||
| // Only do this if we haven't already | ||
| const addQueryParamScript = `if (!window.location.search) { |
There was a problem hiding this comment.
@lankybutmacho there was in fact a real flicker, it was being caused by this JS injection causing an infinite loop of loading (so the loading indicator kept briefly showing up). I believe the change in an update to react-native-webview calling pushState would now trigger a reload of the page.
My fix is just to check if we've already appended the params and if so don't do it again
lankybutmacho
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates everything using the latest
react-native-builder-bobversion. I stared from scratch then copied over all of oursrc/files from the original.