Skip to content

Templates sock reviews #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Templates sock reviews #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f7e4c3
Exercise 1 - Currency
YannickManfroy5 May 31, 2024
727bf8e
Revert "Exercise 1 - Currency"
YannickManfroy5 May 31, 2024
b0f7d51
Templates - sock reviews
YannickManfroy5 May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions itenium-socks/src/app/socks/sock-reviews.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
@if ((reviews$ | async)?.length === 0){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATTENTION:
Heb je de network tab in de gaten gehouden?
Ben je hier 2x de reviews aan het ophalen?

<div class="container">
<div class="heading_container heading_center">
<h3>
Be the first to review these fantastic socks!
</h3>
</div>
</div>
} @else {
<section class="client_section layout_padding" style="padding-top: 0">
<div class="container">
<div class="heading_container heading_center">
Expand Down Expand Up @@ -40,3 +49,4 @@ <h6>On {{ review.added }} by {{ review.email }}</h6>
</div>
</div>
</section>
}
9 changes: 7 additions & 2 deletions itenium-socks/src/app/socks/sock-reviews.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { AsyncPipe, NgFor } from '@angular/common';
import { Component } from '@angular/core';
import {Component, Input} from '@angular/core';
import { Observable } from 'rxjs';
import { SocksService } from './socks.service';
import { Review } from './sock.model';
Expand All @@ -11,11 +11,16 @@ import { Review } from './sock.model';
templateUrl: './sock-reviews.component.html'
})
export class SockReviewsComponent {
@Input() sockId!: number | undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Het ! wil zeggen dat de value altijd gezet is (voor TypeScript, niet voor Angular)
Voor Angular is dat met @Input({required: true}) sockId: number

Aangezien je hier undefined ook accepteert

@Input() sockId: number;

reviews$!: Observable<Review[]>;

constructor(private socksService: SocksService) {}

ngOnInit(): void {
this.reviews$ = this.socksService.getLatestReviews();
if(this.sockId){
this.reviews$ = this.socksService.getSockReviews(this.sockId);
} else {
this.reviews$ = this.socksService.getLatestReviews();
}
}
}
2 changes: 1 addition & 1 deletion itenium-socks/src/app/socks/sock.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ <h1 style="margin-top: 25px;">{{ sock.name }}</h1>
</div>
</section>


<app-sock-reviews [sockId]="this.sockId"></app-sock-reviews>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi :: in de template kan je de this. laten vallen (weeral 5 characters code minder ;) )


<section class="contact_section" style="margin-bottom: 36px">
<div class="container px-0">
Expand Down
8 changes: 5 additions & 3 deletions itenium-socks/src/app/socks/sock.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,24 @@ import { Observable } from 'rxjs';
import { Sock } from './sock.model';
import { SocksService } from './socks.service';
import { AsyncPipe, NgIf, TitleCasePipe } from '@angular/common';
import { SockReviewsComponent } from "./sock-reviews.component";

@Component({
selector: 'app-sock',
standalone: true,
imports: [NgIf, AsyncPipe, TitleCasePipe],
imports: [NgIf, AsyncPipe, TitleCasePipe, SockReviewsComponent],
templateUrl: './sock.component.html'
})
export class SockComponent {
sock$!: Observable<Sock>;
sockId: number | undefined;

constructor(private socksService: SocksService) {}

ngOnInit(): void {
// HACK: This is not the way to get the sockId!!
const sockId = +window.location.pathname.split('/')[2];
this.sock$ = this.socksService.getById(sockId);
this.sockId = +window.location.pathname.split('/')[2];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probeer fields altijd te vermijden.

Een van de oefeningen is "Maak een next button om naar de volgende sock te gaan"
Hiervoor moet je dan een ngOnChanges gaan doen (en later nog andere dingen)

Je kan vb met een getter werken:

get sockId(): number {
  return +window.location.pathname.split('/')[2];
}

(maar natuurlijk is die window.location NOT the Angular way to go! (nog een andere oefn;)

this.sock$ = this.socksService.getById(this.sockId);
}

buy(): void {
Expand Down