This repository contains a subset of a Ruby on Rails app. There are 3 models.
Articles are a type of Posting. Other types of Postings include Questions and ProductReviews.
Postings have a body attribute. The contents of the Posting is stored as raw html. Some Postings have images embedded within the text of the Posting, in the form of an <img> tag wrapped in <figure> tags.
The repo also contains one view file and one spec file.
Throughout the site, "posting snippets" are displayed, with links to read the full Posting. The product manager has decided that when an Article contains an image, its snippet should display the image above the snippet body. If an Article contains multiple images, only the first image should be displayed.
You are the developer assigned to review the code that was created for this feature. As you review the code, try to answer the following questions:
- Does the implementation achieve the desired effect?
- What are the shortcomings of this implementation?
- Does the code adhere to best practices?
- How might you implement this differently?
The code includes a unit test, which passes. What is wrong with this unit test? How could it be improved?
Fork this repository. You can either add comments to the existing code explaining what is wrong and/or what you would change and why. Or you can rewrite the feature, highlighting in the comments what was problematic with the original implementation and providing justification for your decisions. Please put a link to your public repository into the answer section of the question.